Skip to content

Add Inovelli VZM32 MMwave Presence Sensing Switch attributes#4552

Merged
TheJulianJES merged 5 commits intozigpy:devfrom
InovelliUSA:inovelli-vzm32
Feb 25, 2026
Merged

Add Inovelli VZM32 MMwave Presence Sensing Switch attributes#4552
TheJulianJES merged 5 commits intozigpy:devfrom
InovelliUSA:inovelli-vzm32

Conversation

@InovelliUSA
Copy link
Copy Markdown
Contributor

Proposed change

Additional information

Device diagnostics

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.29%. Comparing base (35d1fc1) to head (866799f).
⚠️ Report is 51 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4552      +/-   ##
==========================================
+ Coverage   92.28%   92.29%   +0.01%     
==========================================
  Files         371      371              
  Lines       12158    12174      +16     
==========================================
+ Hits        11220    11236      +16     
  Misses        938      938              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES self-assigned this Dec 6, 2025
@TheJulianJES TheJulianJES added needs review This PR should be reviewed soon, as it generally looks good. priority: medium This should be addressed or looked at soon manufacturer This request was made by the device's manufacturer labels Dec 6, 2025
@InovelliUSA InovelliUSA changed the title Inovell - updating support for VZM32 MMwave Presence Sensing Switch Inovelli - updating support for VZM32 MMwave Presence Sensing Switch Dec 6, 2025
@InovelliUSA
Copy link
Copy Markdown
Contributor Author

@TheJulianJES is there anything else I need to do to this PR to get it merged?

@TheJulianJES
Copy link
Copy Markdown
Collaborator

I don't think so. I'll take a proper look at this and other PRs when I'm back. From a quick glance, this looks good.

@kenspangler
Copy link
Copy Markdown

@TheJulianJES is there an estimated time this change will be merged and in the production build. I am installing these switches now and will hold off installing the custom quirks if this will be soon. Otherwise, I will continue with the custom quirks. Thanks.

Comment thread zhaquirks/inovelli/__init__.py Outdated
Comment thread zhaquirks/inovelli/__init__.py Outdated
Comment thread zhaquirks/inovelli/__init__.py Outdated
@wingrunr21
Copy link
Copy Markdown

@TheJulianJES can this PR get merged? it's coming up on being open for 2 months now

Copy link
Copy Markdown
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry about the delay. I was busy with a lot of other things.
We'll still need to support this in ZHA though. That won't be in 2026.3.0 unfortunately.

Inovelli devices are a bit special because they still have custom entities defined in ZHA itself. They can be moved to quirks but the unique_id_suffix needs be correctly set to match old entities from ZHA. IIRC it's clusterId-attributeId.

We'll look at either merging the ZHA PR until we move Inovelli entities directly to quirks, or directly do that with the new entities.

@TheJulianJES TheJulianJES changed the title Inovelli - updating support for VZM32 MMwave Presence Sensing Switch Add Inovelli VZM32 MMwave Presence Sensing Switch attributes Feb 25, 2026
@TheJulianJES TheJulianJES merged commit becb068 into zigpy:dev Feb 25, 2026
9 checks passed
@InovelliUSA
Copy link
Copy Markdown
Contributor Author

Thanks. Sorry about the delay. I was busy with a lot of other things. We'll still need to support this in ZHA though. That won't be in 2026.3.0 unfortunately.

Inovelli devices are a bit special because they still have custom entities defined in ZHA itself. They can be moved to quirks but the unique_id_suffix needs be correctly set to match old entities from ZHA. IIRC it's clusterId-attributeId.

We'll look at either merging the ZHA PR until we move Inovelli entities directly to quirks, or directly do that with the new entities.

Thanks, I was hoping we could move the entities to the v2 quirk but hopefully the ZHA change can be merged before that work gets started. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manufacturer This request was made by the device's manufacturer needs review This PR should be reviewed soon, as it generally looks good. priority: medium This should be addressed or looked at soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants