Add Inovelli VZM32 MMwave Presence Sensing Switch attributes#4552
Add Inovelli VZM32 MMwave Presence Sensing Switch attributes#4552TheJulianJES merged 5 commits intozigpy:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4552 +/- ##
==========================================
+ Coverage 92.28% 92.29% +0.01%
==========================================
Files 371 371
Lines 12158 12174 +16
==========================================
+ Hits 11220 11236 +16
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@TheJulianJES is there anything else I need to do to this PR to get it merged? |
|
I don't think so. I'll take a proper look at this and other PRs when I'm back. From a quick glance, this looks good. |
|
@TheJulianJES is there an estimated time this change will be merged and in the production build. I am installing these switches now and will hold off installing the custom quirks if this will be soon. Otherwise, I will continue with the custom quirks. Thanks. |
|
@TheJulianJES can this PR get merged? it's coming up on being open for 2 months now |
TheJulianJES
left a comment
There was a problem hiding this comment.
Thanks. Sorry about the delay. I was busy with a lot of other things.
We'll still need to support this in ZHA though. That won't be in 2026.3.0 unfortunately.
Inovelli devices are a bit special because they still have custom entities defined in ZHA itself. They can be moved to quirks but the unique_id_suffix needs be correctly set to match old entities from ZHA. IIRC it's clusterId-attributeId.
We'll look at either merging the ZHA PR until we move Inovelli entities directly to quirks, or directly do that with the new entities.
Thanks, I was hoping we could move the entities to the v2 quirk but hopefully the ZHA change can be merged before that work gets started. :) |
Proposed change
Additional information
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black